fix: fix keras compat with TF_USE_LEGACY_KERAS in tensorflow <2.15 #40391
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Tensorflow 2.16 made keras 3 the default https://github.com/tensorflow/tensorflow/releases/tag/v2.16.1
Since huggingface does not support keras 3 yet, this compat logic was introduced in df15425
However, in tensorflow 2.15, keras is still keras 2, meaning we don't need
tf-keras
at this point. However, since thisTF_USE_LEGACY_KERAS
is set unconditionally (even in 2.15):import tf_keras
This change slightly modifies the environment modification to only happen if tf_keras is available. If it is available, we ensure tensorflow also uses it internally. If its not available, we go into the
except
block and use rawkeras
Repro
With tensorflow 2.15 installed
after this change
Note: there is no current associated issue but i can make one if necessary
Who can review?
@Rocketknight1 based on linked commit