Skip to content

fix: fix keras compat with TF_USE_LEGACY_KERAS in tensorflow <2.15 #40391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: fix keras compat with TF_USE_LEGACY_KERAS in tensorflow <2.15 #40391

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions src/transformers/modeling_tf_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,17 +80,18 @@

logger = logging.get_logger(__name__)

if "TF_USE_LEGACY_KERAS" not in os.environ:
os.environ["TF_USE_LEGACY_KERAS"] = "1" # Compatibility fix to make sure tf.keras stays at Keras 2
elif os.environ["TF_USE_LEGACY_KERAS"] != "1":
logger.warning(
"Transformers is only compatible with Keras 2, but you have explicitly set `TF_USE_LEGACY_KERAS` to `0`. "
"This may result in unexpected behaviour or errors if Keras 3 objects are passed to Transformers models."
)

try:
import tf_keras as keras
from tf_keras import backend as K

if "TF_USE_LEGACY_KERAS" not in os.environ:
os.environ["TF_USE_LEGACY_KERAS"] = "1" # Compatibility fix to make sure tf.keras stays at Keras 2
elif os.environ.get("TF_USE_LEGACY_KERAS", None) not in ("true", "True", "1"):
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

notice this was changes from just checking 1 to match what tensorflow checks for

https://github.com/tensorflow/tensorflow/blob/de7cbafcf424869fbf1d7aa9f9b39c87e23329a6/tensorflow/python/util/lazy_loader.py#L129

logger.warning(
"Transformers is only compatible with Keras 2, but you have explicitly unset `TF_USE_LEGACY_KERAS`. "
"This may result in unexpected behaviour or errors if Keras 3 objects are passed to Transformers models."
)

except (ModuleNotFoundError, ImportError):
import keras
from keras import backend as K
Expand Down